Skip to content

Corrections and Mute option added #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoseMendesGouveia wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Corrections and Mute option added #260

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f8a4288
Update SCRecordSession.m
JoseMendesGouveia Jan 5, 2016
722a074
Update SCRecordSession.m
JoseMendesGouveia Jan 6, 2016
86864a0
Update SCPlayer.m
JoseMendesGouveia Jan 11, 2016
b5457c2
Merge pull request #1 from JoseMendesGouveia/fix/temp_buffer_fix
JoseMendesGouveia Jan 11, 2016
5f8cbd0
Update SCRecorder.m
JoseMendesGouveia Jan 14, 2016
fd3e2d0
Update SCRecorder.h
JoseMendesGouveia Jan 14, 2016
fd2bef6
Merge pull request #2 from JoseMendesGouveia/feature/addMute
JoseMendesGouveia Jan 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update SCPlayer.m 
Correction for the bug in the player showing a black screen.
  • Loading branch information
@JoseMendesGouveia
JoseMendesGouveia committed Jan 11, 2016
commit 86864a075267ab50cfbf3e933a6a60082f0287d5
4 changes: 3 additions & 1 deletion Library/Sources/SCPlayer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ - (id)init {
self = [super init];

if (self) {
_shouldSuppressPlayerRendering = YES;
_shouldSuppressPlayerRendering = NO;

@rFlex rFlex Jan 19, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want this to be false by default?

@JoseMendesGouveia JoseMendesGouveia Jan 20, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent black screen bug, when playing a movie preview.

[self addObserver:self forKeyPath:@"currentItem" options:NSKeyValueObservingOptionNew context:ItemChanged];
}

Expand Down Expand Up @@ -321,6 +321,8 @@ - (void)setItemByAsset:(AVAsset *)asset {
}

- (void)setItem:(AVPlayerItem *)item {
[self unsetupDisplayLink];
[self setupDisplayLink];

@rFlex rFlex Jan 19, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What those these two lines fix?

@JoseMendesGouveia JoseMendesGouveia Jan 20, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same previous bug, to prevent black screen bug, when playing a movie preview.

[self replaceCurrentItemWithPlayerItem:item];
}

Expand Down