Skip to content

Conversation

@rickardraysearch
Copy link
Contributor

@rickardraysearch rickardraysearch commented Aug 11, 2017

What does this implement/fix? Explain your changes.

The recent PR that updated codecov to 2.0.9 broke uploading of C# coverage. This PR is intended to restore that.

Does this close any currently open issues?

No.

Any other comments?

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@den-run-ai den-run-ai changed the title Explicitly specify files to upload to codecov [WIP] Explicitly specify files to upload to codecov Aug 11, 2017
@codecov
Copy link

codecov bot commented Aug 11, 2017

Codecov Report

Merging #527 into master will decrease coverage by 11.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #527       +/-   ##
===========================================
- Coverage   88.57%   77.12%   -11.45%     
===========================================
  Files           2       65       +63     
  Lines         210     5547     +5337     
  Branches        0      889      +889     
===========================================
+ Hits          186     4278     +4092     
- Misses         24      981      +957     
- Partials        0      288      +288
Flag Coverage Δ
#setup_linux 75.71% <ø> (ø) ⬆️
#setup_windows 76.47% <ø> (+5.26%) ⬆️
Impacted Files Coverage Δ
src/runtime/interfaceobject.cs 50% <0%> (ø)
src/runtime/eventobject.cs 78.2% <0%> (ø)
src/runtime/iterator.cs 81.81% <0%> (ø)
src/runtime/constructorbinder.cs 54.54% <0%> (ø)
src/runtime/overload.cs 58.33% <0%> (ø)
src/runtime/extensiontype.cs 74.07% <0%> (ø)
src/runtime/modulepropertyobject.cs 0% <0%> (ø)
src/runtime/converter.cs 82.02% <0%> (ø)
src/runtime/typemethod.cs 0% <0%> (ø)
src/runtime/methodbinding.cs 80% <0%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae7219e...122f71d. Read the comment docs.

@rickardraysearch rickardraysearch changed the title [WIP] Explicitly specify files to upload to codecov Explicitly specify files to upload to codecov Aug 11, 2017
@rickardraysearch
Copy link
Contributor Author

Okay, now the behavior seems to be back to normal. Merge?

@den-run-ai den-run-ai merged commit af62a1a into pythonnet:master Aug 11, 2017
testrunner123 pushed a commit to testrunner123/pythonnet that referenced this pull request Sep 22, 2017
* Explicitly specify files to upload to codecov

* Produce coverage.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants