Fix check in PyScope so that we don't leak a reference. #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PyObject_TYPE` does not `Incref` the type object returned, in contrast to `PyObject_Type`, which was used here before.
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
==========================================
+ Coverage 76.38% 76.41% +0.03%
==========================================
Files 64 64
Lines 5573 5572 -1
Branches 896 895 -1
==========================================
+ Hits 4257 4258 +1
+ Misses 1021 1020 -1
+ Partials 295 294 -1
Continue to review full report at Codecov.
|
den-run-ai
approved these changes
Jun 20, 2017
testrunner123
pushed a commit
to testrunner123/pythonnet
that referenced
this pull request
Sep 22, 2017
`PyObject_TYPE` does not `Incref` the type object returned, in contrast to `PyObject_Type`, which was used here before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyObject_TYPEdoes notIncrefthe type object returned, in contrast toPyObject_Type, which was used here before.