Skip to content

Switch periodic cleanup task to call_later#913

Merged
bdraco merged 1 commit intopython-zeroconf:masterfrom
bdraco:cache_cleanup_schedule
Jul 17, 2021
Merged

Switch periodic cleanup task to call_later#913
bdraco merged 1 commit intopython-zeroconf:masterfrom
bdraco:cache_cleanup_schedule

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jul 17, 2021

  • Simplifies AsyncEngine to avoid the long running
    task

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 17, 2021

Codecov Report

Merging #913 (99bb003) into master (b2a7a00) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #913      +/-   ##
===========================================
+ Coverage   99.95%   100.00%   +0.04%     
===========================================
  Files          22        22              
  Lines        2336      2333       -3     
  Branches      389       387       -2     
===========================================
- Hits         2335      2333       -2     
+ Partials        1         0       -1     
Impacted Files Coverage Δ
zeroconf/_core.py 100.00% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a7a00...99bb003. Read the comment docs.

@bdraco bdraco force-pushed the cache_cleanup_schedule branch 3 times, most recently from 983f908 to 3bec211 Compare July 17, 2021 06:59
- Simplifies AsyncEngine to avoid the long running
  task
@bdraco bdraco force-pushed the cache_cleanup_schedule branch from 3bec211 to 99bb003 Compare July 17, 2021 06:59
@bdraco bdraco merged commit 38eb271 into python-zeroconf:master Jul 17, 2021
@bdraco bdraco deleted the cache_cleanup_schedule branch July 17, 2021 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants