Remove duplicate unregister_all_services code#910
Merged
bdraco merged 1 commit intopython-zeroconf:masterfrom Jul 17, 2021
Merged
Remove duplicate unregister_all_services code#910bdraco merged 1 commit intopython-zeroconf:masterfrom
bdraco merged 1 commit intopython-zeroconf:masterfrom
Conversation
- Switch to using run_coro_with_timeout from sync context - A safe-guard has been added to close to prevent blocking the event loop when Zeroconf.close is called from asyncio as unregister_all_services is a blocking operation (and always has been)
bdraco
force-pushed
the
unregister_all_dedupe
branch
from
b956cb1 to
bfc5dc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using run_coro_with_timeout from sync context
A safe-guard has been added to close to prevent blocking
the event loop when Zeroconf.close is called from asyncio
as unregister_all_services is a blocking operation (and
always has been)