Skip to content

Comments

Make AAAA records work (closes #52)#191

Merged
jstasiak merged 4 commits intopython-zeroconf:masterfrom
dtantsur:ipv6
Oct 17, 2019
Merged

Make AAAA records work (closes #52)#191
jstasiak merged 4 commits intopython-zeroconf:masterfrom
dtantsur:ipv6

Conversation

@dtantsur
Copy link
Collaborator

This PR incorporates changes from the earlier PR #179 (thanks to Mikael Pahmp), adding tests and a few more fixes to make AAAA records work in practice.

Note that changing addresses to container IPv6 addresses may be considered a breaking change, for example, for consumers that unconditionally apply inet_aton to them. I'm introducing a new function to be able to retries only addresses from one family.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 91.33% when pulling a732de1 on dtantsur:ipv6 into ea64265 on jstasiak:master.

@jstasiak
Copy link
Collaborator

Are those mypy errors actually related to the patch? I need to have a look, maybe a mypy update made it check more code.

@jstasiak jstasiak merged commit 5bb9531 into python-zeroconf:master Oct 17, 2019
@jstasiak
Copy link
Collaborator

Cheers, I rebased this on top of updated master and it seems to work fine. BTW it's probably worth looking at the opendrop python-zeroconf changes and see if we can merge them.

@dtantsur
Copy link
Collaborator Author

@jstasiak sure, is there a summary of the changes anywhere?

@dtantsur
Copy link
Collaborator Author

Also could you please release the changes?

@jstasiak
Copy link
Collaborator

I'm thinking if maybe addresses should stick to returning just IPv4 addresses to maintain compatibility. Also I'd like to try to merge the opendrop changes so that if there's some API change it'll be contained in this release and not spread in multiple versions. The summary is "essentially adding rudimentary IPv6 and AWDL support" as far as I understand.

@dtantsur
Copy link
Collaborator Author

I'm thinking if maybe addresses should stick to returning just IPv4 addresses

I was very close to implementing this, just wanted talking to you first. I can do it next week.

Also I'd like to try to merge the opendrop changes

I couldn't find a good diff. I can obviously just diff two files, but I cannot promise it will yield anything useful :)

@jstasiak
Copy link
Collaborator

Sorry, didn't want to imply you do the work to merge this, I actually wanted to do it myself if time permits, I'll try to have a look.

@dtantsur
Copy link
Collaborator Author

Great! I'll look into the addresses problem today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants