Make AAAA records work (closes #52)#191
Conversation
|
Are those mypy errors actually related to the patch? I need to have a look, maybe a mypy update made it check more code. |
|
Cheers, I rebased this on top of updated master and it seems to work fine. BTW it's probably worth looking at the opendrop python-zeroconf changes and see if we can merge them. |
|
@jstasiak sure, is there a summary of the changes anywhere? |
|
Also could you please release the changes? |
|
I'm thinking if maybe |
I was very close to implementing this, just wanted talking to you first. I can do it next week.
I couldn't find a good diff. I can obviously just diff two files, but I cannot promise it will yield anything useful :) |
|
Sorry, didn't want to imply you do the work to merge this, I actually wanted to do it myself if time permits, I'll try to have a look. |
|
Great! I'll look into the |
This PR incorporates changes from the earlier PR #179 (thanks to Mikael Pahmp), adding tests and a few more fixes to make AAAA records work in practice.
Note that changing
addressesto container IPv6 addresses may be considered a breaking change, for example, for consumers that unconditionally applyinet_atonto them. I'm introducing a new function to be able to retries only addresses from one family.