Conversation
* Listen on respond_sockets in addition to listen_socket * Do not bind to respond_sockets in multicast mode
Collaborator
|
Thanks @estyrke. With this patch you can discover services in both corporate and other networks, right? |
Author
|
@jstasiak, I'm afraid I have not tested for any regressions in other cases, or indeed very much at all. It's just something that seemed to work for me at the time. |
This was referenced May 31, 2020
Collaborator
This was referenced May 31, 2020
jstasiak
added a commit
that referenced
this pull request
Jul 7, 2020
This contains two major changes: * Listen on data from respond_sockets in addition to listen_socket * Do not bind respond sockets to 0.0.0.0 or ::/0 The description of the original change by Emil: <<< Without either of these changes, I get no replies at all when browsing for services using the browser example. I'm on a corporate network, and when connecting to a different network it works without these changes, so maybe it's something about the network configuration in this particular network that breaks the previous behavior. Unfortunately, I have no idea how this affects other platforms, or what the changes really mean. However, it works for me and it seems reasonable to get replies back on the same socket where they are sent. >>> The tests pass and it's been confirmed to a reasonable degree that this doesn't break the previously working use cases. Additionally this removes a memory leak where data sent to some of the respond sockets would not be ever read from them (#171). Co-authored-by: Emil Styrke <[email protected]>
Collaborator
|
Merged in fc92b1e. |
Collaborator
|
This has been released in 0.28.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without either of these changes, I get no replies at all when browsing for services using the browser example. I'm on a corporate network, and when connecting to a different network it works without these changes, so maybe it's something about the network configuration in this particular network that breaks the previous behavior.
Unfortunately, I have no idea how this affects other platforms, or what the changes really mean. However, it works for me and it seems reasonable to get replies back on the same socket where they are sent.