Skip to content

Some code fixes to make sure IPv6 addresses are recorded and returned… #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miphip wants to merge 1 commit into from
Closed

Some code fixes to make sure IPv6 addresses are recorded and returned… #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion zeroconf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1607,7 +1607,7 @@ def get_name(self):
def update_record(self, zc: 'Zeroconf', now: float, record: DNSRecord) -> None:
"""Updates service information from a DNS record"""
if record is not None and not record.is_expired(now):
if record.type == _TYPE_A:
if record.type in [_TYPE_A, _TYPE_AAAA]:
assert isinstance(record, DNSAddress)
# if record.name == self.name:
if record.name == self.server:
Expand All @@ -1622,6 +1622,7 @@ def update_record(self, zc: 'Zeroconf', now: float, record: DNSRecord) -> None:
self.priority = record.priority
# self.address = None
self.update_record(zc, now, zc.cache.get_by_details(self.server, _TYPE_A, _CLASS_IN))
self.update_record(zc, now, zc.cache.get_by_details(self.server, _TYPE_AAAA, _CLASS_IN))
elif record.type == _TYPE_TXT:
assert isinstance(record, DNSText)
if record.name == self.name:
Expand All @@ -1639,6 +1640,7 @@ def request(self, zc: 'Zeroconf', timeout: float) -> bool:
record_types_for_check_cache = [(_TYPE_SRV, _CLASS_IN), (_TYPE_TXT, _CLASS_IN)]
if self.server is not None:
record_types_for_check_cache.append((_TYPE_A, _CLASS_IN))
record_types_for_check_cache.append((_TYPE_AAAA, _CLASS_IN))
for record_type in record_types_for_check_cache:
cached = zc.cache.get_by_details(self.name, *record_type)
if cached:
Expand Down