Some code fixes to make sure IPv6 addresses are recorded and returned…#179
Closed
miphip wants to merge 1 commit intopython-zeroconf:masterfrom
Closed
Some code fixes to make sure IPv6 addresses are recorded and returned…#179miphip wants to merge 1 commit intopython-zeroconf:masterfrom
miphip wants to merge 1 commit intopython-zeroconf:masterfrom
Conversation
Collaborator
|
I'm wondering, is it possible/easy to write a test for this or add the relevant code to existing test(s)? |
Collaborator
|
Will returning AAAA addresses break existing code? I'd expect a lot of people doing |
Collaborator
jstasiak
pushed a commit
that referenced
this pull request
Oct 17, 2019
This PR incorporates changes from the earlier PR #179 (thanks to Mikael Pahmp), adding tests and a few more fixes to make AAAA records work in practice. Note that changing addresses to container IPv6 addresses may be considered a breaking change, for example, for consumers that unconditionally apply inet_aton to them. I'm introducing a new function to be able to retries only addresses from one family.
Collaborator
|
I believe all changes from this PR have been included in #191. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… when browsing.
With these changes I could successfully find services with either ip_version=IpVersion.All, V4Only or V6Only. The returned service info would contain all the address records found in the service reponses.
(Great library, by the way!)