Add support for multiple addresses when publishing a service#170
Merged
jstasiak merged 5 commits intopython-zeroconf:masterfrom May 22, 2019
Merged
Add support for multiple addresses when publishing a service#170jstasiak merged 5 commits intopython-zeroconf:masterfrom
jstasiak merged 5 commits intopython-zeroconf:masterfrom
Conversation
This was referenced May 20, 2019
* Raise deprecation warnings when address is used * Add a compatibility property to avoid breaking existing code (based on suggestion by Bas Stottelaar in PR python-zeroconf#27) * Make addresses keyword-only, so that address can be eventually removed and replaced with it without breaking consumers * Raise TypeError instead of an assertion on conflicting address and addresses
Due to psf/black#759 black produces code that is invalid Python 3.5 syntax even with --target-version py35. This patch disables reformatting for this call (it doesn't seem to be possible per line) until it's fixed.
Collaborator
|
Nice! |
Collaborator
|
I'm thinking – maybe it makes sense to keep |
Collaborator
Author
|
I'm on the fence about this. I don't think writing |
Collaborator
|
Yeah, you're probably right. |
|
Could you make a new release? This is actually fixing a bug where a |
Collaborator
|
@balloob Sure, version 0.23.0 has just been released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebased and fixed version of PR #27, which also adds compatibility shim for ServiceInfo.address and does a proper deprecation for it.