Fix type definition of CallbackQuery.edit_message_reply_markup(reply_markup=...)#2271
Closed
blueset wants to merge 1 commit intopython-telegram-bot:masterfrom
Closed
Fix type definition of CallbackQuery.edit_message_reply_markup(reply_markup=...)#2271blueset wants to merge 1 commit intopython-telegram-bot:masterfrom
blueset wants to merge 1 commit intopython-telegram-bot:masterfrom
Conversation
Contributor
Author
|
For the failing tests in this PR, the testing bots in the CI are hitting floot limit, which was not caused by any changes made in the PR. |
Member
|
Hi. Thanks for the PR! We already have #2240 which includes this change, though. So I'll go ahead and close, but I want to emphasize that contributions are welcome ;) |
Contributor
Author
|
Thanks for the comment! I tried to find if the fix was alraedy done by someone else, but it turns out the search feature of GitHub isn’t looking into the actual diffs. 😄 Looking forward to #2240 to be merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type definition of
CallbackQuery.edit_message_reply_markup(reply_markup=...)CallbackQuery.edit_message_reply_markupcalls to eitherBot.edit_message_reply_markup(...), orMessage.edit_reply_markup(...)Bot.edit_message_reply_markup(...)In
Bot.edit_message_reply_markup, the argumentreply_markupis of typeOptional[InlineKeyboardMarkup]which clears the inline keyboard of the message when set toNone. However, theNonebranch of the type definition is not found in theCallbackQuery.edit_message_reply_markup(...)method.This PR fixes this issue.