command.py: Add support for alert_notification PDU (replaces PR #20)#27
Merged
code-of-kpp merged 2 commits intopython-smpplib:masterfrom May 27, 2017
Merged
command.py: Add support for alert_notification PDU (replaces PR #20)#27code-of-kpp merged 2 commits intopython-smpplib:masterfrom
code-of-kpp merged 2 commits intopython-smpplib:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for alert_notification PDUs which openbsc SMPP generates each time a phone attaches to or detaches from the GSM network.
Without this patch an alert_notification PDU generates an assert inside the program using python-smpplib
[ This adds to very minor change to hopefully allow the PR. The original contributor did the work for me, and I know they are pretty busy. ]