Skip to content

Add some basic typechecking support #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidshepherd7 wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add some basic typechecking support #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c98e821
Remove end-of-life'd python versions from circleCI
davidshepherd7 Aug 29, 2021
bcee943
Fix invalid emacs coding value
davidshepherd7 Aug 29, 2021
12e6bae
Remove six dependency
davidshepherd7 Aug 29, 2021
3f4ca13
Fix a test depending on the configured warning filter
davidshepherd7 Aug 29, 2021
c71141c
MVP type checking with minimal code changes
davidshepherd7 Aug 29, 2021
9a4464f
Fix test mock client having a missing required method
davidshepherd7 Aug 29, 2021
1700848
Explicitly fail when a Param has no max or size
davidshepherd7 Aug 29, 2021
3a1b17b
Add easy types
davidshepherd7 Aug 29, 2021
daabdbe
Add a simpler repr for command objects
davidshepherd7 Aug 29, 2021
7bc5c07
Fix inconsistent use of null unicode vs null bytes when generating so…
davidshepherd7 Aug 29, 2021
882a784
Add more tests for PDU parsing/generating
davidshepherd7 Aug 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@ workflows:
- test-3.7
- test-3.6
- test-3.5
- test-3.4
- test-2.7
- test-pypy3
- test-pypy2
jobs:
test-3.9: &test-template
docker:
Expand All @@ -31,11 +28,16 @@ jobs:
command: |
. venv/bin/activate
pip install -e .[tests]
- run:
name: Typecheck
command: |
. venv/bin/activate
venv/bin/mypy -p smpplib
- run:
name: Run tests
command: |
. venv/bin/activate
pytest -v
pytest -v smpplib
test-3.8:
<<: *test-template
docker:
Expand All @@ -52,19 +54,7 @@ jobs:
<<: *test-template
docker:
- image: python:3.5-alpine
test-3.4:
<<: *test-template
docker:
- image: python:3.4-alpine
test-2.7:
<<: *test-template
docker:
- image: python:2.7-alpine
test-pypy3:
<<: *test-template
docker:
- image: pypy:3-slim
test-pypy2:
<<: *test-template
docker:
- image: pypy:2-slim
14 changes: 14 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@

venv:
python -m venv venv

deps:
pip install -e .[tests]

typecheck:
. venv/bin/activate
venv/bin/mypy -p smpplib

test:
. venv/bin/activate
pytest -v smpplib
21 changes: 21 additions & 0 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
[mypy]

strict_optional = True
no_implicit_optional = True
warn_unused_configs = True
strict_equality = True
warn_unused_ignores = True

check_untyped_defs = True

disallow_untyped_calls = True
disallow_untyped_defs = True
disallow_incomplete_defs = True
disallow_untyped_decorators = True
disallow_any_generics = True

[mypy-smpplib/tests/*]

disallow_untyped_calls = False
disallow_untyped_defs = False
disallow_incomplete_defs = False
3 changes: 1 addition & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@
url='https://github.com/podshumok/python-smpplib',
description='SMPP library for python',
packages=find_packages(),
install_requires=['six'],
extras_require=dict(
tests=('pytest', 'mock'),
tests=('pytest', 'mock', 'mypy', 'types-mock'),
),
zip_safe=True,
classifiers=(
Expand Down
Loading