Add query_format to attachment search - #120
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 85.29% 85.37% +0.08%
==========================================
Files 11 11
Lines 2122 2161 +39
==========================================
+ Hits 1810 1845 +35
- Misses 312 316 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for the PR. If you could indeed add some tests for this that would be nice |
Collaborator
|
Please rebase from master and add some changelog as well please :-) Thanks 🙈 |
Contributor
Author
|
@sim0nx Added a small test, let me know what you think |
Collaborator
|
looks good to me, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds a
query_formatparameter to sync/asyncget_attachmentsmethods. Similar argument already exists for many other available methods likesearch, get_ticket, get_asset, etc.Personally I'm using it to fetch the
TransactionIdfor each attachment in order to find the attachments connected to the Create transaction.Let me know if you'd like to see some new tests covering this addition