Skip to content

Conversation

@vrindger
Copy link

Here's the change proposed for #167. This fixed the issue and passed tests when I was testing it locally. Please approve and release as soon as feasible. This has become critical for us again. Thanks!

@apdavison
Copy link
Contributor

Unfortunately, this is breaking some tests - see https://travis-ci.org/github/python-quantities/python-quantities/builds/681112615

(I don't know why the Travis results aren't showing up here in the PR)

@vrindger
Copy link
Author

vrindger commented May 5, 2020

I just looked at one and it already looks pretty serious: https://travis-ci.org/github/python-quantities/python-quantities/jobs/681112616

I'm not sure how else could we fix this issue then.

FAIL: test_std (quantities.tests.test_methods.TestQuantityMethods)

Traceback (most recent call last):
File "/home/travis/build/python-quantities/python-quantities/quantities/tests/test_methods.py", line 261, in test_std
self.methodWithOut('std', 1.1180339887498949 * pq.m)
File "/home/travis/build/python-quantities/python-quantities/quantities/tests/test_methods.py", line 128, in methodWithOut
result
File "/home/travis/build/python-quantities/python-quantities/quantities/tests/common.py", line 34, in assertQuantityEqual
% (delta, q1.magnitude, q2.magnitude, msg)
AssertionError: Magnitudes differ by more than 1e-05 (1.25 vs 1.11803398875)

@vrindger
Copy link
Author

vrindger commented May 5, 2020

Hi @apdavison ,
Is it possible to add a test for numpy 1.15.1 and Python 2.7.15. That's what we are using and have deployed a custom build with this change already. If this test fails, I would need to revert to the regular quantities package.

apdavison added a commit to apdavison/python-quantities that referenced this pull request May 6, 2020
@apdavison
Copy link
Contributor

apdavison commented May 6, 2020

@vrindger I've added a "Python 2.7 + Numpy 1.15.1" entry to the test matrix (we actually get Python Python 2.7.17 not 2.7.15, but I don't believe that will make any difference).

This combination passes on the master branch. I think you'll have to add a commit to this PR to trigger the tests to run again with the new Numpy 1.15.1 test.

@vrindger
Copy link
Author

vrindger commented May 7, 2020

Thanks @apdavison

I triggered a fresh set of Travis tests with a non-change commit.
I see that there was just one test that failed and it's a backward compatibility test? This does not look very serious to me. What are your thoughts?
https://travis-ci.org/github/python-quantities/python-quantities/jobs/684481440

ERROR: test_backward_compat (quantities.tests.test_persistence.TestPersistence)
A few pickles collected before fixing #113 just to make sure we remain backwards compatible.

@apdavison
Copy link
Contributor

@vrindger sorry we didn't get this merged. We've now dropped support for Python 2.7, so I'm closing this PR now.

@apdavison apdavison closed this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants