info: fix metadata build error propagation#9870
Merged
abn merged 2 commits intopython-poetry:mainfrom Nov 28, 2024
Merged
Conversation
e62c95a to
c305c6d
Compare
radoering
reviewed
Nov 24, 2024
Member
There was a problem hiding this comment.
Nice. Have you thought about adding the indentation of the inner error and/or the listing of possible reasons also at
poetry/src/poetry/installation/executor.py
Lines 316 to 322 in c70cbf4
Member
Author
|
Yeah. But figured I'll do that in a separate PR just to keep things clean here. I also wanted to see if we can unify that somehow. Once this is accepted I can work on that, ie. No one has objections to the formatting. |
Secrus
reviewed
Nov 25, 2024
Member
Author
|
@radoering @Secrus I have now also unified the changes for executor and info as well here. |
b9518af to
5c825e1
Compare
abn
commented
Nov 25, 2024
140130c to
b27ea61
Compare
radoering
reviewed
Nov 26, 2024
radoering
reviewed
Nov 26, 2024
b27ea61 to
ca4ceb1
Compare
radoering
approved these changes
Nov 28, 2024
ca4ceb1 to
6b0d0f6
Compare
This change fixes a regression that caused the swallowing of PEP517 build errors when isolated builds fail during metadata build.
6b0d0f6 to
f308e32
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a regression that caused the swallowing of PEP517 build errors when isolated builds fail during metadata build.
Borrowing from another issue, you can use the following
pyproject.tomlto reproduce/test.Output w/ Poetry (1.8.4)
Output w/ Poetry (git@main)
Output w/ PR
You can test this pull request using the following command. You can swap podman with docker if you use that.
You can also preview the changes on asciinema.