Conversation
23224c9 to
a099eeb
Compare
a099eeb to
04c984f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #8362 - I'm hoping to break down that PR into easier-to-review chunks.
A tile's
argsmight be a tuple, string or None.Pillow/src/PIL/ImageFile.py
Lines 101 to 105 in c8d98d5
Assert that
argsis a tuple before accessing a value by index._getmpmay return a dict or None.Pillow/src/PIL/JpegImagePlugin.py
Line 528 in c8d98d5
Assert that it is not None before using a key.
Pixel access might return a tuple or a float.
Pillow/src/PIL/_imaging.pyi
Lines 13 to 14 in c8d98d5
Assert that it is a tuple before checking one of the channel values.
load()might return None.Pillow/src/PIL/Image.py
Line 880 in c8d98d5
Assert that it isn't None before getting pixel data for a particular co-ordinate.
getcolors()might return None.Pillow/src/PIL/Image.py
Lines 1411 to 1413 in c8d98d5
Assert that it isn't None before checking how much a colour is used.