Conversation
radarhere
changed the title
Member
Author
|
I've pushed another commit for RGBA saving. While you would look at the spec and conclude that you should be able to specify the order of the channels arbitrarily using the bit masks, checking the results with ImageMagick I didn't find this to work. Instead, I've swapped the RGBA channels before saving so that it becomes ARGB, the example for the bit masks - https://docs.microsoft.com/en-us/windows/win32/direct3ddds/dds-pixelformat. |
radarhere
force-pushed
the
dds
branch
2 times, most recently
from
8231337 to
17203a2
Compare
23 tasks
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Jun 30, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps #4864 by adding DDS saving. https://docs.microsoft.com/en-us/windows/win32/direct3ddds/dds-header was used as a reference.
Also, a minor cleanup change. Uses this existing line
Pillow/src/PIL/DdsImagePlugin.py
Line 50 in 45003b7
to make
Pillow/src/PIL/DdsImagePlugin.py
Lines 130 to 131 in 45003b7
clearer.