Codecov Report

Merging #38 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #38      +/-   ##
=========================================
+ Coverage   69.86%   69.9%   +0.04%     
=========================================
  Files           4       4              
  Lines         989     987       -2     
=========================================
- Hits          691     690       -1     
+ Misses        298     297       -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caeed16...2eabf08. Read the comment docs.

Pull Request Test Coverage Report for Build 19

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.04%) to 69.909%

Totals
Change from base Build 18:	0.04%
Covered Lines:	690
Relevant Lines:	987

💛 - Coveralls

Anybody watching have an opinion on this change?

The issue at hand here is differentiating how pressure was provided within the METAR. As it stands currently, if SLP is provided and altimeter is not, the SLP value is assigned into the press attribute. On the other hand, the range in ratio between these two values (ignore the units) is rather tight. For example a query against my database for Denver ASOS

select max(alti / mslp), min(alti / mslp) from t2017 where
station = 'DEN' and alti is not null and mslp is not null;
    max    |    min    
-----------+-----------
 0.0298447 | 0.0292443

My code change also removes the option of having the SLP value appear before the remarks section. So my ingestor has been running with this change for a while now and I haven't gotten downstream complaints of how my database stores pressure. I have been wrong in the past though!

For non-US METARs, the WMO specification only seems to provide Q group encoding, which I believe is the Altimeter value.

Oh @phobson sorry, i see you approved this and I didn't really answer your question. The press_sea_level attribute is still set on the receipt of SLP within the METAR.