Ensure T-group temperatures are consistent with previously parsed temperatures#183
Ensure T-group temperatures are consistent with previously parsed temperatures#183akrherz wants to merge 2 commits intopython-metar:mainfrom
Conversation
|
Thanks for the reviews. I am crossing checking my understanding of the world with my METAR archive. One thing that seems clear is that the integer temperature values are truncated and not rounded. ie That's why this PR's check does the greater than 1 degree comparison :/ I did a check of all US METAR data for July 2024 and found 33 examples of failures. ie |
|
It's tempting to fine tune things like this, even if not always
a good idea. Maybe you could relax the cutoff for throwing a warning to 3
degrees, or 5 degrees? In that example, it's seems obvious that you'd want
to keep the Tgroup temperatures. I'm curious whether it's as clear-cut in
the other 32 cases you found?
The problem with throwing an error, here, is that the person who gets the
error isn't generally going to be in a position to do anything about it,
beyond ignoring that report You can't propagate the error to the person
responsible for the report.
Tom
…On Fri, Jul 26, 2024 at 8:19 AM daryl herzmann ***@***.***> wrote:
Thanks for the reviews. I am crossing checking my understanding of the
world with my METAR archive. One thing that seems clear is that the integer
temperature values are truncated and not rounded. ie
KLYO 260855Z AUTO 15004KT 10SM CLR 21/17 A3009 RMK AO2 T02150171
That's why this PR's check does the greater than 1 degree comparison :/
I did a check of all US METAR data for July 2024 and found 33 examples of
failures. ie
KBYY 261055Z AUTO 26003KT 7SM RA SCT015 BKN042 OVC100 22/22 A2999 RMK AO2 P0002 T02370232
—
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYY553OI5W3V7BLZQM3LZOI5DRAVCNFSM6AAAAABLKJQ7EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJSGY2DIMBRGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
@tomp Yeah, I am getting cold feet on this PR and instead think we should create a t-group temperature attribute to hold the parsed value and let the end user decide what to do when then they do not agree. Additionally, I asked about this on X and got this poll result |
|
So, what I a proposing now is
|
|
The current behavior is correct. I might throw a warning if there's a significant discrepancy, but I wouldn't do anything beyond that. I'm not crazy about adding tgroup_temp and tgroup_dewpt fields. It would be more useful just to report those values in the warning. |
I thought that too, but now I am not so certain. Interestingly, the previously used label of Now the source of concern is the lack of documentation that states that the Actual review of METARs in the wild continues to show a horrific story, with these two values not always agreeing. Heaven help us. |
|
I'll confess I'm not sure what should happen here and the final outcome likely won't affect my use case of METAR data. I'm curious if Ryan May got back to you directly on that tweet though. |
|
@phobson , you have a good memory, I don't think he did, but its lame Twitter/X. I'll egregiously tag him here @dopplershift as I know how much he loves issues like this and will hopefully somewhat interesting for what metpy should do. |
|
I remember it, but no clue if I did respond. Right now MetPy isn't parsing the remarks section. Were we to start, my initial thoughts is that we'd have separate columns, with maybe an option to combine them or perhaps a combined column; or maybe the temperature/dewpoint columns would reflect the combined and both raw values would be reported in their own columns. A warning when there's a discrepancy also seems useful. |

My feelings would not be hurt if this PR is rejected by the reviewers here. This PR also includes a related change to update the hopefully only internally used labels to define what the T-group is. It was likely a previous copy/paste as Temp1Hour
closes #182