remove unused position.getdistance API#155
Merged
akrherz merged 1 commit intopython-metar:mainfrom Dec 28, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 87.68% 88.43% +0.74%
==========================================
Files 4 4
Lines 1056 1046 -10
==========================================
- Hits 926 925 -1
+ Misses 130 121 -9
Continue to review full report at Codecov.
|
phobson
approved these changes
Dec 28, 2021
Collaborator
|
feel free to send hate mail my way |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suppose this could be considered an API break, but we ourselves have no code touching this codepath. We'll document it in the changelog and I can take the blame if the community comes with pitchforks.
closes #130
closes #109
refs #110