Skip to content

illegal temperature will raise ParserError#152

Merged
akrherz merged 1 commit intopython-metar:masterfrom
sfo:fix_temperature
Oct 5, 2021
Merged

illegal temperature will raise ParserError#152
akrherz merged 1 commit intopython-metar:masterfrom
sfo:fix_temperature

Conversation

@sfo
Copy link
Contributor

@sfo sfo commented Oct 4, 2021

Values for temperature and dew point should be 2 digits only. According to this comment it might be beneficial to allow 1-digit values as well.

This fixes #136 .

@codecov-commenter
Copy link

Codecov Report

Merging #152 (953c5eb) into master (2f1be43) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files           4        4           
  Lines        1056     1056           
=======================================
  Hits          925      925           
  Misses        131      131           
Impacted Files Coverage Δ
metar/Metar.py 89.89% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1be43...953c5eb. Read the comment docs.

@akrherz akrherz merged commit a0768ef into python-metar:master Oct 5, 2021
@sfo sfo deleted the fix_temperature branch October 7, 2021 06:47
@akrherz akrherz added this to the 1.9 milestone Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parser allows invalid format of temperature group

4 participants

Comments