Skip to content

fix getdistance#130

Closed
jdkloe wants to merge 2 commits intopython-metar:mainfrom
jdkloe:master
Closed

fix getdistance#130
jdkloe wants to merge 2 commits intopython-metar:mainfrom
jdkloe:master

Conversation

@jdkloe
Copy link
Contributor

@jdkloe jdkloe commented Jan 11, 2021

fix getdistance by properly implementing Haversine equation and add a test case.
This should also fix issue #109

@akrherz
Copy link
Collaborator

akrherz commented Jan 11, 2021

Thanks for your PR! In #110, we discussed removing this API as it is not used internally. Are you using it?

@jdkloe
Copy link
Contributor Author

jdkloe commented Jan 11, 2021

Thanks for your reply. I seem to have overlooked PR #110.
No at the moment I don't use this interface, but I noticed warnings when running the pytest sequence, and also the conversion to bytecode causes warnings on this code.
As I am packaging the metar module for Fedora I see this kind of warnings pass by, so wanted to fix them.
Anyway, if you decide these interfaces are not useful I don't feel strong about keeping them. Feel free to remove them.

@akrherz
Copy link
Collaborator

akrherz commented Dec 16, 2021

Hi @phobson , what do you think of removing this code entirely?

@phobson
Copy link
Collaborator

phobson commented Dec 17, 2021

I certainly never use it. 👍🏻 from me

@akrherz
Copy link
Collaborator

akrherz commented Dec 28, 2021

Thanks again for your effort here @jdkloe , we removed the API as discussed within #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants