docs: clarify block_text font parameter#734
Draft
Mirochill wants to merge 1 commit into
Draft
Conversation
belono
approved these changes
Jun 7, 2026
belono
left a comment
belono
left a comment
Contributor
There was a problem hiding this comment.
Hi @Mirochill !
This clarification is very welcome and necessary, as seen in #731 .
You can remove the "Draft" label and leave the pull request open for @patkan to review and integrate.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarifies the
block_text()documentation so thefontparameter is described as a column-width lookup hint whencolumnsis omitted, not as a command that switches the active printer font. The changelog also notes the documentation clarification.Closes #731
Tested with
Not applicable; documentation-only change.
Validation:
git diff --check HEAD~1..HEADsrc/escpos/escpos.pyandCHANGELOG.rst