create_statefbk_iosystem and optimal control enhancements#930
Merged
murrayrm merged 5 commits intopython-control:mainfrom Oct 22, 2023
Merged
create_statefbk_iosystem and optimal control enhancements#930murrayrm merged 5 commits intopython-control:mainfrom
murrayrm merged 5 commits intopython-control:mainfrom
Conversation
f9256cc to
522a8d7
Compare
522a8d7 to
a40906e
Compare
doc/optimal.rst
Outdated
|
|
||
| .. math:: | ||
|
|
||
| J(x, u) = \sum_{k=0}^{N-1} L(x_k, u_k)\, dt + V \bigl( x_N \bigr). |
Contributor
There was a problem hiding this comment.
why does V(x_N) need big parens but L(.) does not?
Contributor
There was a problem hiding this comment.
above, V(.) gets regular sized parens.
Contributor
|
These seem like obvious improvements to make, so I see no issue with them. Just one tiny note in the comments. |
sawyerbfuller
approved these changes
Oct 20, 2023
727eb8e to
f58b19b
Compare
f58b19b to
5e217ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two primary changes. motivated by some debugging I was doing in #929:
create_statefbk_iosystemfunction now allows you to pass an I/O system instead of the a gain (or gain schedule) for the controller. This allows a more general state feedback controller (like an MPC controller) to be created usingcreate_statefbk_iosystem. (I needed this so that I could gain easy access to the inputs in issue #929, since thefeedbackfunction does not pass through the controller inputs as a system output, butcreate_statefbk_iosystemdoes.)create_mpc_iosystemfunction now properly allows keyword parameters that go to the underlyingOptimalControlProblem, for example setting the minimization method. Prior to this, the keyword parameters were passed toOptimalControlProblembut were also passed toNonlinearIOSystem, where they would generate an error.solve_ocpfunction has been updated to make more clear how the final time point is handled (see issue #929 for some discussion on this).install_examples.ymlworkflow to explicitly include the latest python version, otherwise an early version ofmatplotlibgot installed that was not current enough to work with current code (not sure why this was suddenly required...).