fix control.matlab.lsim bug for discrete time system#765
Merged
bnavigator merged 2 commits intopython-control:mainfrom Aug 25, 2022
Merged
fix control.matlab.lsim bug for discrete time system#765bnavigator merged 2 commits intopython-control:mainfrom
bnavigator merged 2 commits intopython-control:mainfrom
Conversation
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #764. There was a dimension check in
forced_responsefor discrete time systems that occurred before processing of thetransposeparameter. Removing the dimension check (which gets done later, aftertransposeprocessing) fixes the bug. Add a unit test to catch the error and also turned on some tests that were@slycotonlybut that didn't rely on slycot.