Change InputOutputSystem repr to show type, name, inputs, and outputs#699
Closed
roryyorke wants to merge 1 commit intopython-control:mainfrom
Closed
Change InputOutputSystem repr to show type, name, inputs, and outputs#699roryyorke wants to merge 1 commit intopython-control:mainfrom
roryyorke wants to merge 1 commit intopython-control:mainfrom
Conversation
Member
|
I agree that a change would be useful here. More generally, it would be nice to think through what we want to have displayed in various situations:
Finally, PR #710 has a conflicting change since I reset the repr format there to include the type and system name. So an I like the version in this draft PR better, but note that if you get something with lots of inputs and outputs, it could be a bit odd looking. |
Member
|
PR #721 has a portion of this ( |
Contributor
Member
|
This has been implemented since v0.10.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I didn't know about
InputOutputSystem's__str__implementation, and I find the__repr__a bit bare-bones. With this change:This is a draft for comment - if it looks OK, I'll (eventually) improve it and add tests. One improvement I can see already: make the input and output lists a little prettier by removing the quotes.