Round to nearest integer decade for default omega vector#688
Merged
bnavigator merged 4 commits intopython-control:masterfrom Jan 5, 2022
Merged
Round to nearest integer decade for default omega vector#688bnavigator merged 4 commits intopython-control:masterfrom
bnavigator merged 4 commits intopython-control:masterfrom
Conversation
Contributor
Author
bnavigator
commented
Jan 4, 2022
murrayrm
approved these changes
Jan 5, 2022
Member
|
@bnavigator In thinking through this overnight, I wonder if we might want to revert to the old behavior (floor, ceil) and update the documentation to match (+ update the unit tests to avoid the corner case). I'm worried that only going out a half decade might now show the asymptotic frequency response. I'll work up a couple of examples and post an issue so that we can discuss. |
Contributor
Author
|
Hmm, okay. We need to find another way to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes #687.
The docstring for the
_default_frequency_range()function saysThe old code rounded to the floor and ceiling of the range, which occasionally adds another decade to one or the other end of the frequency range if the feature falls just inside of the outermost decade.
The new code rounds to the nearest integer, so it only adds half a decade at minimum.