extrapolation in ufun throwed errors#682
Merged
murrayrm merged 3 commits intopython-control:masterfrom Dec 26, 2021
Merged
Conversation
Member
|
@miroslavfikar It would be great to add a unit test the triggers the error (prior to your fix). |
Member
|
I updated the fix to use extrapolation, since this is what is supposed to happen. The example now runs without throwing and error. (I couldn't figure out how to create a simple unit test since it seem to depend on the integrator asking to sample outside of the time range.) @miroslavfikar It would be useful if you can confirm that the new version gives a correct result for your example. |
Contributor
Author
|
@murrayrm Yes, I confirm, I get the correct results with your commit, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across situation when interpolation of u in ufun was requested beyond the actual time interval. Attached MWE file throws error, proposed modification resolves the issue. There were two possibilities to resolve the issue: either to take the highest value of time known (interpolation) or to prolonge the last interval to the right (extrapolation). I chose the first one to be consistent with already treated case to the left.
testh2.txt