Improved lqe calling functionality #673
Merged
bnavigator merged 3 commits intopython-control:masterfrom Dec 2, 2021
Merged
Conversation
Merged
bnavigator
reviewed
Nov 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
lqe()function to allow it to be called with aStateSpacesystem as the first argument rather than the matrices that define the system. This matches the functionality of thelqrcommand. Docstrings have been updated to reflect the new functionality and to match the notation used forlqra bit better. Unit tests added to cover the new code.This PR has some overlap with #670, so depending on which gets merged first it may be necessary to rebase.