Various docstring edits + fixed plot legends on cruise control example#643
Various docstring edits + fixed plot legends on cruise control example#643murrayrm merged 7 commits intopython-control:masterfrom basicmachines:master
Conversation
|
Oh. I just noticed there's a jupyter notebook version of the cruise control example. I'll have to update that too. |
|
Okay, there's something I don't understand about editing a jupyter notebook. After I make the edits and run the notebook locally, the setup.py test is failing (see test results below): |
examples/cruise.ipynb
Outdated
| "language": "python", | ||
| "name": "python3" | ||
| "name": "conda-env-control-dev-py" |
There was a problem hiding this comment.
This won't work in the test environment.
|
The problem with Jupyter notebooks is that they inherit information from your local machine. So the problem is probably something like One fix is to edit the Jupyter notebook directly (in a text editor) and change the code you want to fix. Then commit that change and test it locally, throwing out the new version of the notebook that will be created when you run it (but still making sure it works). Push that up to GitHub and it should be OK. One caveat is that this will leave the notebook with the old figures, which may not be what you want. Alternatively, run the notebook on your local machine and get things working, then go in and manually change the line that said |
No description provided.