Change step_info undershoot percentage calculation#590
Merged
bnavigator merged 5 commits intopython-control:masterfrom Mar 25, 2021
Merged
Change step_info undershoot percentage calculation#590bnavigator merged 5 commits intopython-control:masterfrom
bnavigator merged 5 commits intopython-control:masterfrom
Conversation
Improper systems with negative respose, if do not have inverse respons, the undershoot must be 0. This ocurr in the MIMO system used in the step_info test. I think, the rise time and setting minimun and maximun computed by this funtion are right in.
bnavigator
reviewed
Mar 24, 2021
juanodecc
commented
Mar 24, 2021
Contributor
Author
juanodecc
left a comment
juanodecc
left a comment
There was a problem hiding this comment.
ok... now I see
Contributor
Author
|
@bnavigator can you check it. Tank |
bnavigator
reviewed
Mar 25, 2021
bnavigator
reviewed
Mar 25, 2021
bnavigator
reviewed
Mar 25, 2021
bnavigator
changed the title
bnavigator
force-pushed
the
step_info_improve_undershoot
branch
from
b957dee to
14a92fe
Compare
Contributor
|
I pushed some style cleanups and a I think I have a cleaner formula for the undershoot. Please check. |
sawyerbfuller
approved these changes
Mar 25, 2021
Contributor
sawyerbfuller
left a comment
sawyerbfuller
left a comment
There was a problem hiding this comment.
looks good. removed one array search - > faster - > good
Contributor
|
Thanks @juanodecc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improper systems with negative respose, if do not have inverse
respons, the undershoot must be 0.
This ocurr in the MIMO system used in the step_info test.
I think, the rise time and setting minimun and maximun computed
by this funtion are right in.