MIMO impulse and step response#514
Merged
murrayrm merged 3 commits intopython-control:masterfrom Jan 20, 2021
Merged
Conversation
control/timeresp.py
Outdated
| If present, the response represents ony the listed input. | ||
|
|
||
| output : int, optional | ||
| If present, the response represents ony the listed input. |
Contributor
There was a problem hiding this comment.
Suggested change
| If present, the response represents ony the listed input. | |
| If present, the response represents only the listed output. |
sawyerbfuller
approved these changes
Jan 20, 2021
Contributor
sawyerbfuller
left a comment
There was a problem hiding this comment.
Looks good to me with one small doc change.
also: not changed in this PR but maybe the right place to fix it: on line 20 in config.py is a duplicated setting:
'control.squeeze_time_response': True,
This was referenced Jan 20, 2021
6e64f92 to
28bbe7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements MIMO impulse and step responses, mirroring the style and functionality of frequency response functions for MIMO systems. It resolves issue #512 and is consistent with the discussion issue #453. Specifically:
step_responseorimpulse_responsewill generate an array of responses (indexed by output, input, and time).squeeze=Truekeyword.squeeze=Falsekeyword.Note that the response for
initial_responseandforced_responseis not indexed by the input (since there is no input in one case and a specifically applied input in the other). The processing of thesqueezekeyword is the same: by default SISO systems will be returned without the output axis, usesqueeze=Trueto remove single dimensional axes from MIMO systems, usesqueeze=Falseto force SISO systems to be treated like MIMO systems.Other (small changes):
transposekeyword was working: it changed [output, input, time] to [time, input, output] instead of [time, output, input]. This was caught when adding unit tests.