generate error for tf2ss of non-proper transfer function#492
Merged
bnavigator merged 2 commits intopython-control:masterfrom Dec 31, 2020
Merged
generate error for tf2ss of non-proper transfer function#492bnavigator merged 2 commits intopython-control:masterfrom
bnavigator merged 2 commits intopython-control:masterfrom
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #399 when
tf2iois called with a non-proper transfer function (which cannot be represented as a state space system). The underlying issue turned out to be intf2ss, which had the same bug and was probably introduced in PR #370 when we started allowing non-proper transfer functions.Added unit tests to catch the case and then fixed them by generating a
ValueErrorwhen you try to convert a non-proper transfer function into aStateSpaceobject.Also did some PEP8 cleanup on
statesp.py.