updated markov() to add tranpose keyword + default warning#478
Merged
murrayrm merged 3 commits intopython-control:masterfrom Dec 28, 2020
Merged
updated markov() to add tranpose keyword + default warning#478murrayrm merged 3 commits intopython-control:masterfrom
murrayrm merged 3 commits intopython-control:masterfrom
Conversation
Contributor
|
This PR itself LGTM. But are we sure that the algorithm actually works for real data? The data used in the test is worthless to determine any markov parameters. (#395 (comment)) |
Member
Author
|
Good point on whether the calculation was right. Looks like it wasn't... In this latest push, I have:
|
bnavigator
approved these changes
Dec 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses issue #395 by adding a
transposekeyword to themarkovfunction that allows transposed inputs. In the current release, themarkovfunction is not consistent with the normal time-series convention (see discussion in #395) so a warning message is generated iftransposeis not set explicitly toTrue.These files will need to be updated again in the 0.9.0 release so that the default for the
transposekeyword changes fromTruetoFalse.