Merged
Conversation
… docstring updated to indicate that Q matrix can be >2 columns
This was referenced Dec 19, 2020
Contributor
|
Looks good to me. One minor stylistic comment: you don't need |
bnavigator
requested changes
Dec 19, 2020
Contributor
bnavigator
left a comment
bnavigator
left a comment
There was a problem hiding this comment.
Looks good, thanks! One step closer to 0.8.4 🎉
Some more comments about style and the tests.
| sys = ctrl.feedback(1, frd) | ||
| self.assertTrue(isinstance(sys, ctrl.FRD)) | ||
|
|
||
| def testConnect(self): |
Contributor
There was a problem hiding this comment.
These tests only look for failures. What about tests that successfully connect systems?
Obviously I will pytest.parametrize this for #438
Contributor
Author
There was a problem hiding this comment.
These tests only look for failures. What about tests that successfully connect systems?
good idea; added.
Obviously I will pytest.parametrize this for #438
thx!
bnavigator
approved these changes
Dec 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug in index check in
bdalg.connectdescribed in #421.Also added a few more checks, helpful error messages, and unit tests.