Extend returnScipySignalLTI() to discrete systems#445
Merged
bnavigator merged 1 commit intopython-control:masterfrom Dec 29, 2020
Merged
Extend returnScipySignalLTI() to discrete systems#445bnavigator merged 1 commit intopython-control:masterfrom
bnavigator merged 1 commit intopython-control:masterfrom
Conversation
bnavigator
force-pushed
the
extend-tf2scipylti
branch
from
cf0b866 to
a8aa41e
Compare
Contributor
|
Returning a cont-time scipy system when dt=None seems like a reasonable choice (I think in scipy, dt=None actually means cont time). |
bnavigator
force-pushed
the
extend-tf2scipylti
branch
from
a3336a4 to
edd29fd
Compare
Contributor
Author
|
Re current CI fail: #456 |
bnavigator
force-pushed
the
extend-tf2scipylti
branch
from
edd29fd to
1e7c714
Compare
bnavigator
force-pushed
the
extend-tf2scipylti
branch
from
1e7c714 to
86069d0
Compare
and add unit tests
bnavigator
force-pushed
the
extend-tf2scipylti
branch
from
86069d0 to
d6d77dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were not covered by the tests, so I wrote some tests and found out it is not that hard to extend them to discrete systems.