avoid log(0) in automatic timevector calculation#441
Merged
bnavigator merged 1 commit intopython-control:masterfrom Aug 18, 2020
Merged
avoid log(0) in automatic timevector calculation#441bnavigator merged 1 commit intopython-control:masterfrom
bnavigator merged 1 commit intopython-control:masterfrom
Conversation
Contributor
|
Good catch. Hadn’t thought about testing for that before. S
On Thu, Jul 30, 2020 at 6:47 PM Ben Greiner ***@***.***> wrote:
The current automatic timevector calculation throws a warning when zero
valued poles are present.
(Switch off display of whitespace changes for review)
------------------------------
You can view, comment on, or merge this pull request online at:
#441
Commit Summary
- no log(0) in automatic timevector calculation
File Changes
- *M* control/timeresp.py
<https://github.com/python-control/python-control/pull/441/files#diff-e216ba2d66c950242b1475a045e3cd33>
(83)
Patch Links:
- https://github.com/python-control/python-control/pull/441.patch
- https://github.com/python-control/python-control/pull/441.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#441>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN74SSIIXBC4JI66UH6NAVDR6IPADANCNFSM4PPDXKGA>
.
--
Sawyer Fuller
Assistant Professor of Mechanical Engineering
Adjunct, Paul G Allen School of Computer Science
University of Washington
http://faculty.washington.edu/~minster/
(Typed with my thumbs)
|
bnavigator
force-pushed
the
zero-poles-time-vector
branch
from
6b66e28 to
920649b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current automatic timevector calculation throws a warning when zero valued poles are present.
(Switch off display of whitespace changes for review)