Conversation
…arning + fix bugs in gangof4 using dB + PEP8, docstring cleanup
This was
linked to
issues
Mar 21, 2020
bnavigator
reviewed
Mar 21, 2020
control/freqplot.py
Outdated
| **kwargs : `matplotlib` plot keyword properties, optional | ||
| Additional keywords (passed to `matplotlib`) | ||
|
|
||
| w |
control/freqplot.py
Outdated
|
|
||
| def nyquist_plot(syslist, omega=None, Plot=True, | ||
| labelFreq=0, arrowhead_length=0.1, arrowhead_width=0.1, | ||
| def nyquist_plot(syslist, omega=None, plot=True, labelFreq=0, |
Contributor
There was a problem hiding this comment.
change to label_freq for the same reason as the change to plot and print_gain?
…move extraneous docstring text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some problems with plotting functions in
python-control:gangof4whendB=True, which was not usingsemilogxfor plottingPlotandPrintGainkeywords toplotandprint_gain, with deprecation warnings (better consistency with the rest ofpython-control).examples/pvtol_nested.pythat was giving spurious zero at infinity