Travis CI update for new/old scipy + improved slycot#169
Travis CI update for new/old scipy + improved slycot#169murrayrm merged 2 commits intopython-control:masterfrom
Conversation
|
Check completed as described above. |
|
Update PR to include new rules for building slycot from source, which allows proper checking against the slycot version of the library. A couple of notes on the implementation:
While I was at it, I made a few other changes:
Some of the Travis builds will still fail for this version since the corrections for |
2 participants
This PR addresses two related issues:
The current version of python-control is incompatible with
scipy-1.0.0and so all checks are failing. In this build script we do explicit checks againstscipy-0.19.0andscipy-1.0.0. This is related to issue Compatibility issue with SciPy 1.0 #164.The way that tests were being done against slycot, they were actually not checking to make sure slycot was installed correctly => they 'succeeded' if slycot failed to install. The new version of the build script separates out the slycot versus non-slycot builds so that this is more obvious. Issue Slycot installation failing in Travis CI #168 describes the issue.
In addition to these changes, I updated the python version numbers to check against to 2.7, 3.5, and 3.6 (versions 3.3 and 3.4 seem old enough that we can stop checking against them).
If this PR works correctly, it should have a revised set of Travis CI checks that succeed on the 0.19.1 version of scipy with slicot not installed, but fail on all other cases.