Conversation
testBalredMatchDC, testGramRc, testGramRo which were introduced in PR #118 use functions that depend on Slycot, so the tests should be skipped if it is not found.
|
Changes here increase runtime for CI builds by approximately 90 seconds (as a sum across all configurations: Python 2.7, 3.3, 3.4, 3.5). There is at least one negative consequence of changes here. Tests that are independent of Slycot are performed twice without potential benefit. However, the marginal gain in computation time and load is small. |
|
Looks good. I assume you saw all the deprecation warnings from scipy. FWIW, an alternative is to use Travis CI's matrix capability; I imagine "with Slycot" and "without Slycot" configurations. Using a matrix setup opens other possibilities:
|
|
This PR looks good to me. Will merge in 24 hours if there are no further comments. |
|
@slivingston: leaving it to you to delete the branch (just in case there is some reason to keep it). |
|
@roryyorke and @murrayrm thanks to both of you for reviews. re #133 (comment):
|
Because tests and parts of
controlthat are used depend on whether Slycot is installed, it is worthwhile to exercise both cases as part of CI testing. This pull request does so. Test coverage is only for the case with Slycot installed (as from before this pull request).The second commit disables tests that depend on Slycot if it is not found. Affected tests were introduced in PR #118.