fix return shape for place_acker (#1190)#1195
Merged
bnavigator merged 3 commits intopython-control:mainfrom Feb 15, 2026
Merged
fix return shape for place_acker (#1190)#1195bnavigator merged 3 commits intopython-control:mainfrom
bnavigator merged 3 commits intopython-control:mainfrom
Conversation
Closed
This was referenced Jan 19, 2026
Closed
Member
Author
|
Also, this bug was pointed out by @guptavaibhav0 in #1181. |
bnavigator
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests to catch the bug in #1190 and fix it. Thanks to @miroslavfikar for pointing out the error.