BugFix: place_acker output should be 2D array#1181
Closed
guptavaibhav0 wants to merge 1 commit intopython-control:mainfrom
Closed
BugFix: place_acker output should be 2D array#1181guptavaibhav0 wants to merge 1 commit intopython-control:mainfrom
place_acker output should be 2D array#1181guptavaibhav0 wants to merge 1 commit intopython-control:mainfrom
Conversation
Member
|
Good fix, @guptavaibhav0! Can you also update the unit test in to read then the previous code will generate an error. |
Member
|
Alternative fix in #1195 with unit tests to catch the bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
place_ackerfunction's output is a 1D array, while it should be a 2D array as described in its doc string.