Fix CI doctest, install-examples#1137
Conversation
Workaround for sphinx-doc/sphinx#13352
|
It would be nice to block out just the version that is failing, if possible, so that we will test against the latest new release when it comes out (and hopefully the bug is fixed). Also, should we put something in |
|
For IPython, it's reasonably likely that an upcoming release, say 9.0.1, will fix this (ipython/ipython#14807 claims to fix it). If it's later, 9.0.2 or whatever, we can update the relevant config file(s) to exclude all the broken version. So here I think the CI fix is OK. For sphinx, the situation is trickier. From sphinx-doc/sphinx#13364 and sphinx-doc/sphinx#13352 , sphinx have made a change that breaks nbsphinx, and nbsphinx has a PR for necessary updates at spatialaudio/nbsphinx#826, but it's not clear when that will be merged and released. I don't think there's a way to say "use nbsphinx >= 0.9.7, or failing that, use sphinx < 8.2.*", so I think the sphinx version condition I've added is a stop-gap until there's a released nbsphinx fix. I know this sort of stop-gap can easily last months (or years), and I don't know what to do about that. I guess a TODO in the I've pushed a prototype of As for pyproject.toml: I don't know if we can or should do anything about IPython. It's a clear bug (install IPython, run |
|
Thanks @roryyorke for the detail comments and the fix. I'll let this sit for a bit (at least rest of the day) before merging, in case others have comments. But I think this is otherwise good to go (and we need to get something in place soon to fix the CI tests for current and upcoming PRs). |
|
IPython 9.0.1 should be out. |
Fixes gh-1136.
I tried '!=8.2' for sphinx-doc, which didn't work, so I used '<8.2'. I think '!=8.2.*' might, but didn't try it. See https://packaging.python.org/en/latest/specifications/version-specifiers/#id5 (not sure this applies to Conda/Mamba - it should).