Constrain NumPy version to 1.X#240
Constrain NumPy version to 1.X#240sdahdah wants to merge 1 commit intopython-control:masterfrom sdahdah:master
Conversation
|
The If not, or if it requires a lot of work, then your proposed change is a good temporary solution. |
|
I think building the wheels with NumPy 2 makes them compatible with NumPy 1 and 2 EDIT: https://numpy.org/doc/stable/dev/depending_on_numpy.html#numpy-2-0-specific-advice |
|
There are no Slycot wheels on PyPI. We only publish the source distribution and it is compatible with NumPy 2. |
My bad, there must be something else wrong on my end. |
|
No worries, feel free to ask if you need more help. You probably just have to recompile/reinstall Slycot with numpy 2. Make sure to not use a previously compiled wheel from your local cache. |
|
Thanks, the problem was actually a previously compiled wheel in my cache. EDIT: To be more specific, the |
It seems that the Slycot wheels on PyPI were built with NumPy 1.X, but the
pyproject.tomlallows NumPy 2.X to be installed.This means that if I create a fresh virtual environment and install Slycot, then it will pull NumPy 2.X, which makes the Slycot import fail.
I've added the version constraint in this PR, but if this is not what you had in mind, feel free to just close without merging.