Skip to content

Enable Python 3.12, drop Python <3.9 #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnavigator merged 4 commits into from
Jan 9, 2024
Merged

Enable Python 3.12, drop Python <3.9 #227

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a375c8
Follow SPEC 0 on 2024Q1
bnavigator Jan 7, 2024
9ad09e9
pull in conda-forge python312 migration pinning
bnavigator Jan 7, 2024
dd1901e
don't check control deprecation warnings
bnavigator Jan 7, 2024
7340cf8
replace coveralls-python with coveralls github-action
bnavigator Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
replace coveralls-python with coveralls github-action
  • Loading branch information
@bnavigator
bnavigator committed Jan 8, 2024
commit 7340cf8fde6b83284315e05f2b78141a34f8e752
1 change: 0 additions & 1 deletion .github/conda-env/test-env.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ dependencies:
- pytest-cov
- pytest-timeout
- coverage
- coveralls >= 3.3
1 change: 1 addition & 0 deletions .github/scripts/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,5 @@ cd ${slycot_srcdir}
echo " ${slycot_libdir}" >> .coveragerc
coverage combine
coverage report
coverage xml
echo "::endgroup::"
31 changes: 13 additions & 18 deletions .github/workflows/slycot-build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,21 +279,19 @@ jobs:
- name: Install Wheel
run: |
python -m pip install --upgrade pip
pip install matplotlib scipy pytest pytest-cov pytest-timeout coverage coveralls
pip install matplotlib scipy pytest pytest-cov pytest-timeout coverage
pip install slycot-wheels/${{ matrix.packagekey }}/slycot*.whl
pip show slycot
- name: Slycot and python-control tests
run: JOBNAME="$JOBNAME" bash slycot-src/.github/scripts/run-tests.sh
env:
JOBNAME: wheel ${{ matrix.packagekey }} ${{ matrix.blas_lib }}
- name: report coverage
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COVERALLS_FLAG_NAME: wheel-${{ matrix.packagekey }}-${{matrix.blas_lib}}
COVERALLS_PARALLEL: true
working-directory: slycot-src
# https://github.com/TheKevJames/coveralls-python/issues/252
run: coveralls --service=github
uses: coverallsapp/github-action@v2
with:
flag-name: wheel-${{ matrix.packagekey }}-${{matrix.blas_lib}}
parallel: true
file: slycot-src/coverage.xml

test-conda:
name: Test conda ${{ matrix.packagekey }}, ${{matrix.blas_lib}} BLAS lib ${{ matrix.failok }}
Expand Down Expand Up @@ -363,14 +361,12 @@ jobs:
run: JOBNAME="$JOBNAME" bash slycot-src/.github/scripts/run-tests.sh
env:
JOBNAME: conda ${{ matrix.packagekey }} ${{ matrix.blas_lib }}
- name: Report coverage
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COVERALLS_FLAG_NAME: conda-${{ matrix.packagekey }}-${{matrix.blas_lib}}
COVERALLS_PARALLEL: true
working-directory: slycot-src
# https://github.com/TheKevJames/coveralls-python/issues/252
run: coveralls --service=github
- name: report coverage
uses: coverallsapp/github-action@v2
with:
flag-name: wheel-${{ matrix.packagekey }}-${{matrix.blas_lib}}
parallel: true
file: slycot-src/coverage.xml

coveralls-final:
name: Finalize parallel coveralls
Expand All @@ -381,7 +377,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Coveralls Finished
uses: coverallsapp/github-action@master
uses: coverallsapp/github-action@v2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel-finished: true