Skip to content

Implement MB02ED #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnavigator merged 13 commits into from
Sep 24, 2023
Merged

Implement MB02ED #214

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
84c9552
mb02ed
saasaa Sep 19, 2023
05fd0b7
fix formatting
saasaa Sep 20, 2023
d373407
added numpydoc style docstring
saasaa Sep 21, 2023
15188ef
fixed typos in docstring
saasaa Sep 21, 2023
bad3c74
Added new test, added checking of input variables
saasaa Sep 23, 2023
7c14647
Merge branch 'python-control:master' into master
saasaa Sep 23, 2023
3a97769
remove checks in wrapper
saasaa Sep 23, 2023
da77ca9
changed Warns to Raises in docstring
saasaa Sep 23, 2023
7da2c4c
remove unused import
saasaa Sep 23, 2023
56609fc
Update docstring, fix checks in signature,
saasaa Sep 23, 2023
bf0d133
remove checks in signature
saasaa Sep 23, 2023
eb93764
Apply suggestions from code review
saasaa Sep 23, 2023
05797af
update docstring
saasaa Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove checks in wrapper
  • Loading branch information
@saasaa
saasaa committed Sep 23, 2023
commit 3a97769f235ccea36600cc78e714927816d745f5
7 changes: 0 additions & 7 deletions slycot/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,6 @@ def mb02ed(typet: str,T: np.ndarray, B: np.ndarray, n: int, k: int, nrhs: int):
"info",
]

if k < 0:
raise SlycotParameterError(message="k must be >= 0",info=-2)
if n< 0:
raise SlycotParameterError(message="n must be >= 0", info=-3)
if nrhs < 0:
raise SlycotParameterError(message="nrhs must be >= 0", info=-4)

T, X, info = _wrapper.mb02ed(typet=typet, k=k, n=n, nrhs=nrhs, t=T, b=B)

raise_if_slycot_error(info, arg_list, docstring=mb02ed.__doc__, checkvars=locals())
Expand Down