Use pip install in conda-build recipes

roryyorke · roryyorke · commit 2894c98160d2 · 2019-06-22T11:13:05.000+02:00
This is recommended by conda-forge; see [1]. It also tests "pip installability". [1] http://conda-forge.org/docs/maintainer/adding_pkgs.html#use-pip
diff --git a/conda-recipe-openblas/bld.bat b/conda-recipe-openblas/bld.bat
@@ -16,7 +16,7 @@ if EXIST "%PREFIX%\Scripts\f2py.exe" (
   set F2PY=%PREFIX%\Scripts\f2py.bat
 )
 
-"%PYTHON%" setup.py install
+"%PYTHON%" -m pip install . --no-deps --ignore-installed -vv
 
 if errorlevel 1 exit 1
 
diff --git a/conda-recipe-openblas/build.sh b/conda-recipe-openblas/build.sh
@@ -11,4 +11,5 @@ export LAPACK_ROOT=${PREFIX}
 rm -rf _skbuild
 
 # do the build
-$PYTHON setup.py install
+$PYTHON -m pip install . --no-deps --ignore-installed -vv
+
diff --git a/conda-recipe-openblas/meta.yaml b/conda-recipe-openblas/meta.yaml
@@ -10,6 +10,7 @@ build:
   string: py{{ environ.get('PY_VER').replace('.', '') }}{{ environ.get('GIT_DESCRIBE_HASH', '') }}_obl_{{ environ.get('GIT_DESCRIBE_NUMBER', 0) }}
 
 requirements:
+  # TODO: pip possibly required in only *one* of build and host, but which?
   build:
     - python {{ PY_VER }}
     - numpy
@@ -21,6 +22,7 @@ requirements:
 
   host:
     - python {{ PY_VER }}
+    - pip
     - flang                     # [win]
     - numpy
     - openblas >=0.3.0
diff --git a/conda-recipe/bld.bat b/conda-recipe/bld.bat
@@ -16,7 +16,7 @@ if EXIST "%PREFIX%\Scripts\f2py.exe" (
   set F2PY=%PREFIX%\Scripts\f2py.bat
 )
 
-"%PYTHON%" setup.py install
+"%PYTHON%" -m pip install . --no-deps --ignore-installed -vv
 
 if errorlevel 1 exit 1
 
diff --git a/conda-recipe/build.sh b/conda-recipe/build.sh
@@ -12,4 +12,4 @@ rm -rf _skbuild
 env
 
 # do the build
-$PYTHON setup.py install
+$PYTHON -m pip install . --no-deps --ignore-installed -vv
diff --git a/conda-recipe/meta.yaml b/conda-recipe/meta.yaml
@@ -14,6 +14,7 @@ requirements:
   # conda-supplied clang and library linking see e.g.
   # https://github.com/conda-forge/mpi-feedstock issue #4
   # conda-forge might have the configuration in place for clang build and link?
+  # TODO: pip possibly required in only *one* of build and host, but which?
   build:
     - python {{PY_VER}}
     - numpy
@@ -24,6 +25,7 @@ requirements:
     
   host:
     - python {{ PY_VER }}
+    - pip
     - flang                     # [win]
     - numpy
     - mkl

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ if EXIST "%PREFIX%\Scripts\f2py.exe" (`
`16`	`16`	`set F2PY=%PREFIX%\Scripts\f2py.bat`
`17`	`17`	`)`
`18`	`18`
`19`		`-"%PYTHON%" setup.py install`
	`19`	`+"%PYTHON%" -m pip install . --no-deps --ignore-installed -vv`
`20`	`20`
`21`	`21`	`if errorlevel 1 exit 1`
`22`	`22`