Fix type annotations for set_global_params and set_default_params#261
Merged
Borda merged 1 commit intopython-cachier:masterfrom Jun 2, 2025
Merged
Conversation
ROCKTAKEY
force-pushed
the
fix-params-type-annotation
branch
from
c32290f to
4c62cee
Compare
Borda
approved these changes
May 28, 2025
Contributor
nice catch, thank you |
shaypal5
force-pushed
the
fix-params-type-annotation
branch
from
4c62cee to
4cd334c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
==========================================
- Coverage 97.84% 95.34% -2.51%
==========================================
Files 8 10 +2
Lines 511 580 +69
Branches 88 67 -21
==========================================
+ Hits 500 553 +53
- Misses 10 21 +11
- Partials 1 6 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thanks for maintenance.
I fixed the wrong type annotations on
set_global_paramsandset_default_params.As we can see Arbitrary argument lists and default argument values,
**kwargs: Ttypeskwargstodict[str, T], notT.Thus on the code bellow:
type of
paramsisdict[str, Mapping], but it should be probablydict[str, Any].