This repository was archived by the owner on Jan 4, 2025. It is now read-only.
Add Feeds utility to convert dict FeedOptions to string#181
Merged
GriceTurrble merged 2 commits intodevelopfrom Jun 26, 2020
Merged
Add Feeds utility to convert dict FeedOptions to string#181GriceTurrble merged 2 commits intodevelopfrom
GriceTurrble merged 2 commits intodevelopfrom
Conversation
Lacrymology
added a commit
to Shiphero/python-amazon-mws
that referenced
this pull request
Jul 10, 2020
* upstream/develop: Add Feeds utility to convert dict FeedOptions to string (python-amazon-mws#181) Ensure correct decoding of bytes (python-amazon-mws#168) Compatibility fix (python-amazon-mws#124) Implement a couple of function for the OutboundShipments API. (python-amazon-mws#96) Added OutboundShipments.create_fulfillment_order (python-amazon-mws#95) added UpdateReportAcknowledgements (python-amazon-mws#101) Update feeds.py (python-amazon-mws#166) added easyship api support for indian marketplace (python-amazon-mws#169) Moving Slack link up, removing gitter chat link add all current marketplaces and alphabetize by country code (python-amazon-mws#155) Updated slack invite link Slack invite link (python-amazon-mws#152) Slack invite link fix clean_params (python-amazon-mws#106) add in NL marketplace information Fix flake8 warnings Update develop branch CI + package metadata include mws.apis in setup.py Fix bug: Remove trailing comma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an enhancement to #166 , this adds a utility function,
feed_options_str, that converts a dict of feed options to the appropriate string value.This is an optional enhancement: users can supply a string value to
feed_optionsthemselves, and this will be passed straight to the request. Otherwise, a dict like the following example:...will be converted to a string by
feed_options_str:This is in accordance with Amazon documentation, here (PDF) (see 6.4 Invoice Upload Feed Type).
"metadata:".TrueandFalseas in other contexts, converting these literals to"true"and"false", respectively.key=value.;as a separator.feed_optionsdict will returnNone, instead.feed_options, aValueErroris raised noting the problem.